-
Notifications
You must be signed in to change notification settings - Fork 834
SPM fix depricated warnings #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickolai-nikishin
wants to merge
1
commit into
openid:master
from
ps-github-wh-mobile:story/nickolai-nikishin/SPM_fix_depricated_warnings
Open
SPM fix depricated warnings #809
nickolai-nikishin
wants to merge
1
commit into
openid:master
from
ps-github-wh-mobile:story/nickolai-nikishin/SPM_fix_depricated_warnings
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the rationale and consequence of this pull request? I don't think we want to suppress warnings, but instead want to fix them.
Some projects who is using AppAuth as SPM dependency may have "treat warnings as errors' enabled so the project will fail to compile. Also it brings some 'noise' in build logs. As soon as minimum iOS version will be revisited and deprications will be fixed, this PR can be obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.