Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes requirements.txt, applies default headers before header params #37

Merged
spacether merged 4 commits into master from fixes_headers_and_requirements
Oct 10, 2022

Conversation

@spacether
Copy link
Contributor

@spacether spacether commented Oct 10, 2022
edited
Loading

Fixes requirements.txt (adds missing typing_extension), uses same libs for setup.py

  • adds missing typing_extension
    • typing_extensions limited to minor version >= for general safety
    • frozendict limited to minor version >= for test success on dict representation
    • python-dateutil limited to minor version >= for isoparser existence
    • urllib3 limited to minor version >= for supports_chunked_reads
    • Note: other libs can be more constrained in the future as needed
  • fixes headers
    • default headers set first then set ones applied on top
    • adds verification tests test_passed_in_header_overrides_default test_default_header_used_when_no_header_params_input

When merged, this will fix:

And those fixes will need to be merged into openapi-generator at a later date

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title (削除) Fixes requirements, fixes headers (削除ここまで) (追記) Fixes requirements.txt, applies default headers before header params (追記ここまで) Oct 10, 2022
@spacether spacether added this to the 1.0.1 milestone Oct 10, 2022
@spacether spacether merged commit 90b32e1 into master Oct 10, 2022
@spacether spacether deleted the fixes_headers_and_requirements branch October 10, 2022 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /