-
Notifications
You must be signed in to change notification settings - Fork 13
fix: bug in componentDidUpdate in base.tsx causing unnecessary rerenders #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://zeit.co/opd/g2plot-react/78dffb2ff
✅ Preview: https://g2plot-react-git-fork-jaym910-master.opd.now.sh
@jaym910 I'd have to revert this commit, thanks your contribution
if we filter function properties in config, chart will not be updated when events changed.
you can reproduce this bug in latet test case in line.spec.tsx
you should use other way like useMemo/useCallback/useRef to persist you config to avoid unnecessary rerenders
Ok, sorry I didn't think of that scenario. And thanks for the tip
Hi great job writing this wrapper lib, its been super useful for me and my company. I fixed a bug that was causing an annoying visual bug where the plots would re-render when a parent component did, even when none of plot component's props were updated.