Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

I have implemented the ASCII art images class #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdtrooper wants to merge 26 commits into ondras:master
base: master
Choose a base branch
Loading
from mdtrooper:master

Conversation

@mdtrooper
Copy link

@mdtrooper mdtrooper commented Sep 27, 2013

Hi.

I have been working to add the ASCII art images class.

The main work is not mine, it is from (jsAscii 0.1

But I have added blit functions and rewrote some parts for to make "rot.js standar".

Regards.

yanno and others added 11 commits February 17, 2013 12:03
check if this._map[x] exists in the _digCallback function
Copy link
Owner

ondras commented Sep 27, 2013

Hi,

*) do you have some publicly viewable demo of this?

*) What exactly does this feature do? Is it generally useful for roguelike games? I am not 100% convinced this is highly relevant to rot.js, although the feature itself sounds interesting.

*) Instead of a new "test.html" page, it might be better to use a standardized place - the interactive manual - to both showcase and document the feature (without jQuery, naturally).

*) This pullrequest cannot be automatically merged as it cretes conflicts.

Copy link
Author

Hi.

  1. Yes, I forget to upload a example (you can see in example directory).

  2. I think that it is good for example the titles and some things that ASCII intros (as Dwarft Fortress intro) or for example if somebody want to implement a combat by turns similar to final fantasy games.

  3. Ok. Where do you want the files?

  4. Ok. I want to help you. And I can make more easy the merge. Do you want to try to merge your fork into the mine? I make this thing in other project (for example https://github.com/mdtrooper/games/network)

Regards.

Copy link

twpage commented Sep 27, 2013

This looks "interesting" but I don't think it fits with rot.js. Better for rot.js to focus on roguelike-specific mechanics.

Copy link

twpage commented Sep 27, 2013

@mdtrooper Thanks for the examples. I actually love DoomRL, I just don't want to see the scope of rot.js expand into something too huge. As it is now it is very targeted specifically on roguelike mechanics, which is a great help for roguelike developers. Certainly nothing is stopping anyone from using a js implementation of this ASCII art converter in their game, but that doesn't mean it should be crammed into rot.js.

Copy link
Author

It is only 4kb, but maybe I could work in the code for to slim.

Copy link

twpage commented Sep 27, 2013

@mdtrooper Size isn't the issue, it's scope. It's up to @ondras though, obviously. Just sharing my opinion on the internet.

tchalvak reacted with thumbs up emoji

Copy link
Author

Yes of course.

Copy link
Owner

ondras commented Sep 30, 2013

I mostly agree with @twpage; while the feature itself is cool (I really love ASCII art!), I am not sure it really fits into rot.js's usage scope.

Let me recap this: the main use case of the discussed code is

  1. take a normal HTML picture as an input,

  2. convert it to an array of coloured characters.

Right? Am I not missing anything?

In a typical development scenario, a (roguelike) developer is almost certainly going to pre-convert his image data into ASCII for some breathtaking intros or so, moving the usage of this code to a development phase. This being said, I actually see the conversion more as a (web) service than a code that forms a part of a rot.js (runtime).

Copy link
Author

Hi.

Well, yes and not, the images are from the server.

But I think that the advantage of generation the ASCII from images in the library is that you can update more easy the ASCII art across the source image.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /