Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement validateRedirectUri model function #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheNoim wants to merge 1 commit into oauthjs:master
base: master
Choose a base branch
Loading
from TheNoim:master

Conversation

@TheNoim
Copy link

@TheNoim TheNoim commented Mar 25, 2018

Why should we not be able to verify our uris by ourself.
// TODO: Add to docs

maxtruxa and yaming116 reacted with thumbs up emoji
Copy link
Member

Hi, to get this merged we'd need some tests & docs please

Copy link
Contributor

@TheNoim Can you describe your use case for this? I'm not quite sure why it's necessary...

Copy link
Author

TheNoim commented Aug 19, 2018

I can not remember my exact use case or in which project I wanted to use this but a basic use case would be one of this:

  • Custom uri support
  • wildcard support if wanted
  • own validation rules

Copy link

+1

redirect_uri doesn't have to be exactly equal to any of the redirectUris. Conditions listed below are acceptable on some occasions.

  • same origin and same pathname but different query
  • same origin but different pathname
  • same domain but different protocol
  • same top level domain
luckv reacted with thumbs up emoji

Copy link

Passing context to all methods also will do the trick.

There are quite a lot of issues depend on this feature:

#536 #336 #150

sm2017 and TheNoim reacted with heart emoji

@thomseddon thomseddon force-pushed the master branch 2 times, most recently from 08f0399 to b84778b Compare May 24, 2020 14:16
Copy link

whlsxl commented Jan 15, 2021

Any update for this pull request?

Copy link

whlsxl commented Jan 15, 2021

Copy link

Push, we realy need wildcard redirect uris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bogdanaks bogdanaks bogdanaks left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /