-
-
Notifications
You must be signed in to change notification settings - Fork 927
252-Allow optional properties in token response by setting 'allowExtended... #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjsalinger
merged 3 commits into
oauthjs:master
from
mjsalinger:252-Allow-optional-properties-in-token-response
Oct 25, 2016
Merged
252-Allow optional properties in token response by setting 'allowExtended... #301
mjsalinger
merged 3 commits into
oauthjs:master
from
mjsalinger:252-Allow-optional-properties-in-token-response
Oct 25, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mjsalinger
mjsalinger
changed the title
(削除) Allow optional properties in token response by setting 'allowExtended... (削除ここまで)
(追記) 252-Allow optional properties in token response by setting 'allowExtended... (追記ここまで)
May 24, 2016
Fixes #252
maxtruxa
added a commit
to maxtruxa/node-oauth2-server
that referenced
this pull request
May 27, 2016
... by setting 'allowExtendedTokenProperties' argument
maxtruxa
maxtruxa
requested changes
Oct 23, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor style issue (a single superfluous space).
lib/server.js
Outdated
options = _.assign({
accessTokenLifetime: 60 * 60, // 1 hour.
refreshTokenLifetime: 60 * 60 * 24 * 14 // 2 weeks.
refreshTokenLifetime: 60 * 60 * 24 * 14, // 2 weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments aren't aligned anymore.
@mjsalinger
mjsalinger
force-pushed
the
252-Allow-optional-properties-in-token-response
branch
from
October 25, 2016 10:45
33d815b to
b1ebe17
Compare
@mjsalinger
mjsalinger
deleted the
252-Allow-optional-properties-in-token-response
branch
October 25, 2016 10:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...TokenProperties' argument