Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Ignore if-modifided-since and if-none-match proxy headers #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davision wants to merge 1 commit into nuxt-community:main
base: main
Choose a base branch
Loading
from davision:main

Conversation

@davision
Copy link

@davision davision commented Jan 13, 2022

Fixes #557

pi0 reacted with thumbs up emoji
@davision davision changed the title (削除) fix: Ignore if-modifided-since and if-none-match proxy headers #557 (削除ここまで) (追記) fix: Ignore if-modifided-since and if-none-match proxy headers (追記ここまで) Jan 13, 2022
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #558 (1115fb1) into main (a99b56c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #558 +/- ##
=======================================
 Coverage 88.67% 88.67% 
=======================================
 Files 1 1 
 Lines 53 53 
 Branches 29 29 
=======================================
 Hits 47 47 
 Misses 6 6 
Impacted Files Coverage Δ
lib/module.js 88.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99b56c...1115fb1. Read the comment docs.

Copy link

@fago fago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it should. see #557 for the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@fago fago fago approved these changes

@christophheich christophheich christophheich approved these changes

@alexieremia alexieremia alexieremia approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If-modified-since and If-none-match headers may break Nuxt when using axios

AltStyle によって変換されたページ (->オリジナル) /