-
Notifications
You must be signed in to change notification settings - Fork 56
implement uploading of files #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kkuepper The RestClient shouldn’t directly interact with the Notion API endpoint. Instead, we need to add a client for the FileUploads API endpoint. I’m not sure whether I missed something in the changelog or if the Notion team hasn’t documented it yet, but we need to add support for the File Uploads endpoint since it remains backward-compatible with the 2022 version.
@kkuepper I will working over this weekend to add support to it. You can refactor your PR once the Client is available or if you are okay I can add support for this.
go ahead. If you make my PR obsolete by your changes, that's very fine by me. Feel free to use it for inspiration or copy & paste what you need.
Uh oh!
There was an error while loading. Please reload this page.
Description
I need the functionality of uploading pictures and attaching them to pages. This PR implements:
The integration test is a bit rough and probably needs to be refactored before it can be merged. If you give me some signals that the rest is fine and that there's a chance for it to be merged, I will take some time to cleanup the tests.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: