Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added Color abstraction (#251) #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KoditkarVedant merged 3 commits into notion-dotnet:main from Sphere10:main
Aug 11, 2022
Merged

Conversation

@HermanSchoenfeld
Copy link
Contributor

@HermanSchoenfeld HermanSchoenfeld commented Aug 5, 2022 •
edited
Loading 

- Color is now an enum in the DTO's
- Added missing Color to ToggleBlock
Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@HermanSchoenfeld There are few checks are failing both are related to code analysis and styling. Try running dotnet format it should resolve most of them.

Can you added the link to the issue you are fixing with this? I believe it is #251, right?

Copy link
Contributor Author

HermanSchoenfeld commented Aug 6, 2022 via email •
edited
Loading

Hi Vedant, can we speak in private? My email is ***@***.***

@HermanSchoenfeld HermanSchoenfeld changed the title (削除) Refactored Color abstraction (削除ここまで) (追記) Fix #251 (追記ここまで) Aug 11, 2022
@HermanSchoenfeld HermanSchoenfeld changed the title (削除) Fix #251 (削除ここまで) (追記) Added Color abstraction (#251) (追記ここまで) Aug 11, 2022
Copy link
Contributor Author

All formatting issues are resolved. I believe the LGTM issue is related to .NET 6 targetting. I've not changed any targets so this is not due to my changes.
KoditkarVedant reacted with thumbs up emoji

@KoditkarVedant KoditkarVedant merged commit 9d6052a into notion-dotnet:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoditkarVedant KoditkarVedant KoditkarVedant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block colors are now supported in the API

AltStyle によって変換されたページ (->オリジナル) /