-
Notifications
You must be signed in to change notification settings - Fork 56
Correct filter models #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
71d0540
Merge pull request #17 from notion-dotnet/add-support-for-block-objec...
KoditkarVedant 6e6b6ef
Merge branch 'develop' of github.com:asevos/notion-sdk-net into develop
27e1749
🚚 Moved filters to separate files
asevos cdce41b
🚚 Move filters to separate files
asevos e5db124
Merge branch 'develop' of github.com:asevos/notion-sdk-net into develop
asevos 6894aa3
🐛 Fix filters formats and property nullability
asevos 2a15e3a
♻️ Change RestClient.defaultSerializerSettings access to protected
asevos 09cc0ff
✅ Adds filter clasees serialization tests
asevos cb7ab54
Merge branch 'main' of github.com:notion-dotnet/notion-sdk-net into main
asevos 9c9028e
♻️ Makes filter conditions a nested filters class
asevos f23b595
✨ Adds filter constructors
asevos 9980587
🎨 Updates code formatting to .editorconfig settings
asevos 128b22c
📝 Db querying docs added to readme
asevos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
208 changes: 0 additions & 208 deletions
Src/Notion.Client/Models/Filter.cs
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
Src/Notion.Client/Models/Filters/Checkbox.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| using System; | ||
| using Newtonsoft.Json; | ||
|
|
||
| namespace Notion.Client | ||
| { | ||
| public class CheckboxFilter : SinglePropertyFilter | ||
| { | ||
| public Condition Checkbox { get; set; } | ||
|
|
||
| public CheckboxFilter( | ||
| string propertyName, | ||
| bool? equal = null, | ||
| bool? doesNotEqual = null) | ||
| { | ||
| Property = propertyName; | ||
| Checkbox = new Condition(equal: equal, doesNotEqual: doesNotEqual); | ||
| } | ||
|
|
||
| public class Condition | ||
| { | ||
| [JsonProperty("equals")] | ||
| public bool? Equal { get; set; } | ||
|
|
||
| [JsonProperty("does_not_equal")] | ||
| public bool? DoesNotEqual { get; set; } | ||
|
|
||
| public Condition(Nullable<bool> equal = null, Nullable<bool> doesNotEqual = null) | ||
| { | ||
| Equal = equal; | ||
| DoesNotEqual = doesNotEqual; | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.