Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change PageSize property from string to int? #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KoditkarVedant merged 1 commit into notion-dotnet:main from hognevevle:main
Sep 28, 2021
Merged

Change PageSize property from string to int? #135

KoditkarVedant merged 1 commit into notion-dotnet:main from hognevevle:main
Sep 28, 2021

Conversation

@hognevevle
Copy link
Contributor

@hognevevle hognevevle commented Sep 28, 2021

Description

Change PageSize property from string to int?

Fixes #134

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant merged commit 7e86091 into notion-dotnet:main Sep 28, 2021
Copy link
Contributor

KoditkarVedant commented Sep 28, 2021
edited
Loading

@hognevevle Thank you for your contribution. 🙌🏼

@KoditkarVedant KoditkarVedant added this to the 1.4.2 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoditkarVedant KoditkarVedant KoditkarVedant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.2

Development

Successfully merging this pull request may close these issues.

Search PageSize property is string instead of int

AltStyle によって変換されたページ (->オリジナル) /