-
-
Notifications
You must be signed in to change notification settings - Fork 54
release 4.1.0 -> master #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added test coverage using nyc
Remove statuses package, use built in http.STATUS_CODES
Replace exception library Should with Chai
For this release, I'd like to just publish this manually -- once #49 is reviewed and further worked on. It can be our strategy moving forward.
@HappyZombies yes I agree with manual publishing for this release, otherwise we would be stuck for a much longer time with outdated code.
Currently reviewing this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've seen this is all the code I have already reviewed in the recent PRs without deviation. From my end this can be published.
@jwerre can you please add your review so @HappyZombies can publish? I already approved.
@jankapunkt yes, I'll check this out today. Sorry for the delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Published!
Summary 📖
This PR merges the changes from development into master.