-
-
Notifications
You must be signed in to change notification settings - Fork 54
Remove lodash dependency #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome, we will take a look at this soon after #30 is merged into development. But so far looks good, excited for this removal.
Hey! I was just getting ready to do this. Thanks @jorenvandeweyer I'll check it out now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have only the one thing to discuss but won't block due to it. I'd rather want to hear what you think. We can also create a separate issue on this one.
@jorenvandeweyer can you please pull development? We merged a few PRs lately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would squash merge this into one commit and name it using our commit conventions. If no one has any arguments against I would proceed.
@jankapunkt I haven't had much time to look at myself but I trust you, you are good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Resolves issue #23