-
-
Notifications
You must be signed in to change notification settings - Fork 54
Add commit message convention and coding rules #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HappyZombies
merged 2 commits into
node-oauth:contribution-guidelines
from
oklas:contrib
Oct 13, 2021
Merged
Add commit message convention and coding rules #32
HappyZombies
merged 2 commits into
node-oauth:contribution-guidelines
from
oklas:contrib
Oct 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@HappyZombies @jwerre what do you think? Can you please take a look at it? It targets to be merged into #18 so we should first finish this one, before merging #18
jankapunkt
jankapunkt
approved these changes
Oct 13, 2021
If nobody is against this I would merge :-)
Looks good to me. And I am excited cuz I never used this git commit convention!
HappyZombies
HappyZombies
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
@HappyZombies
HappyZombies
merged commit Oct 13, 2021
0bb1b23
into
node-oauth:contribution-guidelines
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
It is necessary to use semantics in commit messages so that it is clear what meaning commit have in release process and affected release type (major/minor/patch). The semantics proposed in angular are very widely used - it is really convenient and understandable.
It is also necessary to mention the testing and documentation.