-
-
Notifications
You must be signed in to change notification settings - Fork 54
Replace exception library Should with Chai #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it out and ran the tests, coverage and test resluts are exactly the same, besides being 10ms faster :-)
@HappyZombies you can take a look at it if you want, from my end it is good to go
I will look into it further more today and into tomorrow maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and small indentation. Once resolved I will merge. But looks good on my end too
test/unit/models/token-model_test.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here is off by a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops... I need to set up some workspace setting for this project. It's the only one in which I use spaces ;)
Looks good! Merging.
Resolves issue #28