Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Get free book from newsletter #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niqdev merged 10 commits into niqdev:master from juzim:get-free-book-from-newsletter
Dec 16, 2016

Conversation

@juzim
Copy link
Contributor

@juzim juzim commented Dec 14, 2016

Downloads the free ebook from the link contained in the newsletter

Copy link
Contributor Author

juzim commented Dec 14, 2016

This branch also contains the other recent changes to avoid conflicts.

### free ebook from the newsletter
The script also downloads the free ebook from the weekly newsletter. The url (https://goo.gl/kUciut) is generated by an Google apps script which parses the mail. If you want to use your own source, just adapt url.bookFromNewsletter in the config. The url should point to an csv containing a single line with the url (no semicolon).
You can also [clone the script](https://docs.google.com/spreadsheets/d/1jN5gV45uVkE0EEF4Nb-yVNfIr3o8OoiVveUZJRMiLFw) to use your own Gmail account. Just subscribe to the newsletter (found on the bottom of https://www.packtpub.com) and create a filter to tag your mails accordingly.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, as I asked yesterday, is the google app something that you have done or where it comes from? Do you have the source code? I'd really like to see it. Is something that can be added to this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the full code when you clone the spreadsheet, I will make this more clear in the readme.

Copy link
Owner

niqdev commented Dec 15, 2016

@juzim Do you have the possibility to verify the conflicts?

Copy link
Contributor Author

juzim commented Dec 16, 2016

Not sure what's your position on rebase vs merge, I hope it's ok this way.

Copy link
Owner

niqdev commented Dec 16, 2016

I checked the 3 pull requests, I saw that you did it from different branches, should I merge just the last one i.e. #36 or do you suggest to merge all in order? The problem is that now there is no free ebook and I can't run the script!

Copy link
Owner

niqdev commented Dec 16, 2016

By the way..thanks, you have done a great job!

Copy link
Contributor Author

juzim commented Dec 16, 2016 via email

Yeah, I messed up the commits, sorry. When you merge the newsletter one, you should be able to merge the other 2 on top of it. I will keep an eye on it and fix everything asap but I tested everything manually and it worked fine. Thanks, it was fun working with Python again! I don't think I will have the time to work on this in the next months (it also does everything I want now), but I was thinking that it might be relatively easy to turn it into an modular scraper for free ebooks (think HumbleBundle etc). niqdev <notifications@github.com> schrieb am Fr., 16. Dez. 2016, 21:28:
...
By the way..thanks, you have done a great job! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEmPPI38rsv0z22EE1bhsdAyX2phQqeSks5rIvRwgaJpZM4LM6-8> .

@niqdev niqdev merged commit 3763705 into niqdev:master Dec 16, 2016
Copy link
Owner

niqdev commented Dec 16, 2016 •
edited
Loading

Yep, can you just give me a hand to solve the conflicts, I will ask you only to keep an eye on the project when the ebooks will become available again, if there is any issue and I might need your help.

I'll be busy as well in the next months, but can you explain me better your idea? Do you know any other "daily free ebook" offers?

Copy link
Contributor Author

juzim commented Dec 16, 2016 via email

I will try to get everything working over the weekend. Not daily but regularly. Lots of indie books or the 1$ base tier on HumbleBundle. Amazon also has free books (but they are horrible). Storybundle.com often includes books by authors like Neil Gaiman. I think even O'Reilly has some free offers. niqdev <notifications@github.com> schrieb am Fr., 16. Dez. 2016, 22:54:
...
Yep, can you just give me a hand to solve the conflicts, I will ask you only to keep an eye on the project when the book will become available again if there is an issue and I might need your help. I'll be busy as well in the next months, but can you explain me better your idea? Do you know any other "daily free ebook" offers? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEmPPLy2Wz3V_rz4i-LZuUor1dRxrLs7ks5rIwibgaJpZM4LM6-8> .

@juzim juzim deleted the get-free-book-from-newsletter branch December 20, 2016 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niqdev niqdev niqdev left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /