Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

STY: Apply ruff/pycodestyle rules (E) #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
effigies merged 5 commits into nipy:master from DimitriPapadopoulos:E
Oct 7, 2024
Merged

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 6, 2024

No description provided.

E712 Avoid equality comparisons to `False`;
 use `if not trait.__dict__[key]:` for false checks
E714 Test for object identity should be `is not`
E721 Use `is` and `is not` for type comparisons,
 or `isinstance()` for isinstance checks
Copy link

codecov bot commented Oct 6, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (d3cfb41) to head (e84ada2).
Report is 92 commits behind head on master.

Files with missing lines Patch % Lines
nipype/scripts/utils.py 0.00% 2 Missing ⚠️
nipype/interfaces/fsl/tests/test_base.py 0.00% 1 Missing ⚠️
nipype/pipeline/plugins/dagman.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #3689 +/- ##
=======================================
 Coverage 70.84% 70.84% 
=======================================
 Files 1277 1277 
 Lines 59116 59118 +2 
 Branches 9803 9803 
=======================================
+ Hits 41882 41884 +2 
 Misses 16067 16067 
 Partials 1167 1167 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stylistic suggestion.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit ae12343 into nipy:master Oct 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /