-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Parse commas in CSV fields #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Parse commas in CSV fields #3637
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 63.14%. Comparing base (
c46a957) to head (5e84919).
Report is 7 commits behind head on master.
❗ Current head 5e84919 differs from pull request most recent head f746c34. Consider uploading reports for the commit f746c34 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@ ## master #3637 +/- ## ========================================== - Coverage 63.15% 63.14% -0.01% ========================================== Files 308 308 Lines 40825 40824 -1 Branches 5656 5655 -1 ========================================== - Hits 25781 25780 -1 Misses 14031 14031 Partials 1013 1013
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small cleanup to avoid escaping quotes.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes #3635
List of changes proposed in this PR (pull-request)
csvlibrary to parse CSV files, so that quoted fields are correctly parsed.delimiterfield toCSVReaderso that things like TSVs can be parsed.