Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ENH]: Add functions to mrtrix3 interface #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
effigies merged 19 commits into nipy:master from lbutry:added_mrtrix3_functions
Mar 20, 2024

Conversation

@lbutry
Copy link

@lbutry lbutry commented Oct 24, 2023

This PR updates the mrtrix3 interface in nipype and closes issue #3612

List of proposed changes:

  1. Added "MaskFilter" for dilate/erode filteres
  2. Added "MTnormalise"
  3. Added "Generate5tt2gmwmi"

teanijarv reacted with thumbs up emoji
Copy link
Contributor

What's the status on this PR? I just found as well that mtnormalise doesn't have interface in nipype.

This comment was marked as off-topic.

Copy link
Member

Apologies for the delay. Please review the change I made (apart from the merge fixing up Zenodo author ordering) and the CI complaints.

Once the tests are passing and you're okay with this, we can merge.

Copy link

codecov bot commented Mar 17, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is 78.43137% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 63.16%. Comparing base (f1a8909) to head (27d285a).
Report is 11 commits behind head on master.

❗ Current head 27d285a differs from pull request most recent head 5599348. Consider uploading reports for the commit 5599348 to get more accurate results

Files Patch % Lines
nipype/interfaces/mrtrix3/utils.py 78.43% 11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
+ Coverage 63.14% 63.16% +0.01% 
==========================================
 Files 308 308 
 Lines 40824 40875 +51 
 Branches 5655 5655 
==========================================
+ Hits 25780 25820 +40 
- Misses 14031 14042 +11 
 Partials 1013 1013 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Author

lbutry commented Mar 18, 2024

Thank you for reviewing! The changes you made are all good in my opinion.

Unfortunately, I'm rather new to GitHub and not familiar with the CI complaints. I won't be able to fix them. I would appreciate it very much if someone could help me out here.

@effigies effigies merged commit 28973c5 into nipy:master Mar 20, 2024
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /