-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: update self.inputs.optimization in outputs for GTMPVC #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mnoergaard
mnoergaard
changed the title
(削除) FIX: update sefl.inputs.optimization in outputs for GTMPVC (削除ここまで)
(追記) FIX: update self.inputs.optimization in outputs for GTMPVC (追記ここまで)
May 17, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@ ## master #3571 +/- ## ======================================= Coverage 63.34% 63.34% ======================================= Files 309 309 Lines 40903 40903 Branches 5381 5381 ======================================= Hits 25910 25910 Misses 13985 13985 Partials 1008 1008
☔ View full report in Codecov by Sentry. |
effigies
effigies
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the output specification for 'optimization_schema' in the petsurfer interface GTMPVC.
Fixes #3570 #3570 (comment)
List of changes proposed in this PR (pull-request)