-
Notifications
You must be signed in to change notification settings - Fork 536
Normalize and Normalize12 use "estimate" and not "est" as the jobtype #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Normalize and Normalize12 of SPM use in the _list_outputs method "estimate" as jobtype and not "est". In addition, SPM uses "estimate" for the jobtype.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@ ## master #3569 +/- ## ========================================== - Coverage 63.34% 63.23% -0.12% ========================================== Files 309 309 Lines 40903 40762 -141 Branches 5381 5379 -2 ========================================== - Hits 25910 25774 -136 - Misses 13985 13986 +1 + Partials 1008 1002 -6
☔ View full report in Codecov by Sentry. |
Actually, there are some real problems with estimate job_type in Normalise12 with nipype ... Nipype's SPM Normalize12 process does not work at all with estimate. Bad output files, bad pyscript.m, generated, etc. I am investigating. I think the quick and dirty fix would be to keep est in the input traits and fix the _list_outputs ...
I am closing this PR. The issue requires a bigger change I think and I don't have the time right now. I will open a new and more complete PR about spm.Normalize12 later
Normalize and Normalize12 of SPM use in the _list_outputs method "estimate" as jobtype and not "est". In addition, SPM uses "estimate" for the jobtype.