Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FIX] update sample_random_points and random_seed type of ProbTrackXBaseInputSpec #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@mauriliogenovese
Copy link
Contributor

@mauriliogenovese mauriliogenovese commented Mar 31, 2023

updated random_seed to accept an integer value and sample_random_points to accept a float value

#3534

Copy link
Member

Does this stem from a change in probtrackx or has this always been a deficiency of the interface?

Copy link
Contributor Author

mauriliogenovese commented Mar 31, 2023
edited
Loading

I think probtrackx has always been like that

Copy link
Member

Sorry, I don't know what you're saying "yes" to.

Copy link
Contributor Author

I think probtrackx has always been like that, sry I misread your question and I was updating my reply

effigies reacted with thumbs up emoji

Copy link
Contributor Author

I've found some other similar little inconsistencies. It's ok if I propose other pull requests or do you prefer that I just open issues? I'm not too practiced in git

Copy link
Member

effigies commented Jul 5, 2023

Due to the low maintenance level in nipype (nobody has much time to spend on it), it's probably most efficient to open PRs unless it would be more costly to attempt to fix things before discussing them.

It may also be most efficient to copy/fix interfaces in the packages that use them, so that you are not dependent on our release cycle, which is basically unspecified at this point. Anyway, thanks for this.

@effigies effigies merged commit fb1662a into nipy:master Jul 5, 2023
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /