-
Notifications
You must be signed in to change notification settings - Fork 536
[FIX] update sample_random_points and random_seed type of ProbTrackXBaseInputSpec #3556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] update sample_random_points and random_seed type of ProbTrackXBaseInputSpec #3556
Conversation
Does this stem from a change in probtrackx or has this always been a deficiency of the interface?
I think probtrackx has always been like that
Sorry, I don't know what you're saying "yes" to.
I think probtrackx has always been like that, sry I misread your question and I was updating my reply
I've found some other similar little inconsistencies. It's ok if I propose other pull requests or do you prefer that I just open issues? I'm not too practiced in git
Due to the low maintenance level in nipype (nobody has much time to spend on it), it's probably most efficient to open PRs unless it would be more costly to attempt to fix things before discussing them.
It may also be most efficient to copy/fix interfaces in the packages that use them, so that you are not dependent on our release cycle, which is basically unspecified at this point. Anyway, thanks for this.
updated random_seed to accept an integer value and sample_random_points to accept a float value
#3534