-
Notifications
You must be signed in to change notification settings - Fork 536
CI: Allow tutorial test cancellation #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 65.29% // Head: 64.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #3514 +/- ## ========================================== - Coverage 65.29% 64.41% -0.88% ========================================== Files 309 309 Lines 40873 40873 Branches 5380 5380 ========================================== - Hits 26687 26329 -358 - Misses 13108 13484 +376 + Partials 1078 1060 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is good, as combined with concurrency it will ensure that multiple commits to a release branch don't just flood the the tutorial CI.
Currently, after the tutorial workflow is dispatched, it runs to completion, regardless of our workflow ending early. This adds a step to cancel the workflow upon failure or cancellation, to avoid overbearing the external runners.