-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Ensure loadpkl returns a not None value
#3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A question: Should we be able to pickle None? Or is that just never a useful thing to do?
Should we be able to pickle None? Or is that just never a useful thing to do?
yes. custom dictionary inputs to custom functions. or custom outputs from custom functions.
but never as a stand alone unit in nipype (results, nodes, and crashfiles are always not None)
c178fbb to
19ce2c1
Compare
@effigies, rebased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@ ## master #3020 +/- ## ========================================== - Coverage 64.18% 64.18% -0.01% ========================================== Files 342 342 Lines 43987 43990 +3 Branches 5547 5549 +2 ========================================== + Hits 28233 28234 +1 - Misses 14638 14639 +1 - Partials 1116 1117 +1
Continue to review full report at Codecov.
|
Ref.: #3014 (comment)
Acknowledgment