Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

FIX: Import nibabel reorientation bug fix #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgxd merged 1 commit into nipy:master from effigies:fix/nibabel_reorientation_bug
Apr 9, 2019

Conversation

@effigies
Copy link
Member

@effigies effigies commented Apr 9, 2019

Summary

Fixes #2907 .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

Copy link
Member Author

effigies commented Apr 9, 2019

Replicates the fix in nipy/nibabel#741.

Copy link

Codecov Report

Merging #2912 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #2912 +/- ##
==========================================
- Coverage 67.57% 67.57% -0.01% 
==========================================
 Files 343 343 
 Lines 43648 43645 -3 
 Branches 5429 5428 -1 
==========================================
- Hits 29495 29492 -3 
- Misses 13448 13450 +2 
+ Partials 705 703 -2
Flag Coverage Δ
#smoketests 50.47% <ø> (ø) ⬆️
#unittests 65% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/image.py 73.41% <66.66%> (+1.46%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 65% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e52aa...4a3a42e. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgxd mgxd merged commit 44ed184 into nipy:master Apr 9, 2019
@effigies effigies added this to the 1.2.0 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgxd mgxd mgxd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Latest nibabel release breaks test

AltStyle によって変換されたページ (->オリジナル) /