-
Notifications
You must be signed in to change notification settings - Fork 536
ENH: Allow afni.MaskTool to take multiple input files #2892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
effigies
effigies
approved these changes
Feb 25, 2019
@effigies
effigies
changed the title
(削除) ENH: Allow afni.MaskTool to take multiple input files, 2. attempt (削除ここまで)
(追記) ENH: Allow afni.MaskTool to take multiple input files (追記ここまで)
Feb 25, 2019
codecov-io
commented
Feb 25, 2019
Codecov Report
@@ Coverage Diff @@ ## master #2892 +/- ## ========================================== + Coverage 67.49% 67.68% +0.18% ========================================== Files 343 343 Lines 43598 44327 +729 Branches 5426 5664 +238 ========================================== + Hits 29427 30002 +575 - Misses 13467 13605 +138 - Partials 704 720 +16
Continue to review full report at Codecov.
|
yarikoptic
added a commit
to yarikoptic/nipype
that referenced
this pull request
Mar 15, 2019
1.1.9 (February 25, 2019) Full changelog: https://github.com/nipy/nipype/milestone/30?closed=1 * FIX: Make positional arguments to LaplacianThickness require previous argument (nipy#2848) * FIX: Import math and csv modules for bids_gen_info (nipy#2881) * FIX: Ensure outputs can be listed in camino.ProcStreamlines by defining instance variable (nipy#2739) * ENH: Allow afni.MaskTool to take multiple input files (nipy#2892) * ENH: Add flags dictionary input to spm.Level1Design (nipy#2861) * ENH: Threshold stddev once only in TSNR (nipy#2883) * ENH: Add workbench.CiftiSmooth interface (nipy#2871) * DOC: Replace initialism typo in comment with intended phrase (nipy#2875) * DOC: Fix typos in ANTs Registration input documentation (nipy#2869) * tag '1.1.9': (34 commits) MNT: Update changelog MNT: Add Katherine Bottenhorn, Paul Mihai to Zenodo MNT: Add kchawla-pi to Zenodo, update mailmap and ordering add to zenodo MNT: Update zenodo ordering Update .zenodo.json afni utils.py - masktool - InputMultiPath for in_file argument MNT: Update .zenodo ordering MNT: Add Oliver Contier name to .zenodo.json Update nipype/interfaces/spm/model.py ENH: Add zenodo updating script MNT: Update mailmap to avoid renames in script MNT: Update .mailmap, .zenodo.json MNT: Version 1.1.9 DOC: 1.1.9 changelog ENH: minor - compute non degenerate stddev map once BF: regenerated test_auto_LaplacianThickness using wonderfully long running tools/checkspecs.py TEST: Thorough test of LaplacianThickness requirement cascade FIX: Requires error text was backwards import math and csv modules for bids_gen_info ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2874. its a follow up from #2886 where PR was accidentally closed.
List of changes proposed in this PR (pull-request)
Made a change to the inputs of
MaskToolclass in AFNI interface. UsedInputMultiObjectas suggested, tested it out and now it works fine with multiple input images as well as far as I can tell.Acknowledgment