-
Notifications
You must be signed in to change notification settings - Fork 536
Output warp fields and jacobian correction files in TOPUP. #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nipype/interfaces/fsl/epi.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a suggestion for readability:
ext = Info.output_type_to_ext(self.inputs.output_type) fmt = os.path.abspath('{prefix}_{i:02d}{ext}').format outputs['out_warps'] = [fmt(prefix=self.inputs.out_warp_prefix, i=i, ext=ext) for i in range(1, n_vols + 1)] outputs['out_jacs'] = [fmt(prefix=self.inputs.out_jac_prefix, i=i, ext=ext) for i in range(1, n_vols + 1)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does making these required outputs have the potential to produce large amounts of data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't thinks so. Those files will also be automatically deleted if no used.
codecov-io
commented
Apr 27, 2017
Codecov Report
@@ Coverage Diff @@ ## master #1976 +/- ## ========================================== - Coverage 72.63% 72.63% -0.01% ========================================== Files 1070 1070 Lines 54407 54417 +10 Branches 7857 7860 +3 ========================================== + Hits 39517 39524 +7 - Misses 13659 13662 +3 Partials 1231 1231
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #1976 +/- ## ========================================== - Coverage 72.63% 72.63% -0.01% ========================================== Files 1070 1070 Lines 54407 54417 +10 Branches 7857 7860 +3 ========================================== + Hits 39517 39524 +7 - Misses 13659 13662 +3 Partials 1231 1231
Continue to review full report at Codecov.
|
No description provided.