-
Notifications
You must be signed in to change notification settings - Fork 536
doc: warn contrastmgr deprecation in fsl 5.0.7+ #1940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nipype/interfaces/fsl/model.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if FSL is not installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then FSLVersion would be "0"
nipype/interfaces/fsl/model.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace this section with the version property in FSL base class.
Codecov Report
@@ Coverage Diff @@ ## master #1940 +/- ## ========================================== + Coverage 72.47% 72.47% +<.01% ========================================== Files 1063 1063 Lines 54153 54149 -4 Branches 7811 7811 ========================================== - Hits 39249 39247 -2 + Misses 13684 13682 -2 Partials 1220 1220
Continue to review full report at Codecov.
|
nipype/interfaces/fsl/model.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use DeprecationWarning without import warn
#1140