Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] Support surface-based analysis in FSL #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
effigies wants to merge 1 commit into nipy:master from effigies:level1_surface

Conversation

@effigies
Copy link
Member

@effigies effigies commented Apr 5, 2017

Not sure how huge the scope of this might get. Hopefully it's just some minor tweaks, because my FSL knowledge is super brittle.

Copy link

codecov-io commented Apr 10, 2017
edited
Loading

Codecov Report

Merging #1939 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@
## master #1939 +/- ##
=========================================
- Coverage 72.5% 72.5% -0.01% 
=========================================
 Files 1063 1063 
 Lines 54204 54206 +2 
 Branches 7823 7824 +1 
=========================================
+ Hits 39302 39303 +1 
- Misses 13681 13682 +1 
 Partials 1221 1221
Flag Coverage Δ
#smoketests 72.5% <66.66%> (-0.01%) ⬇️
#unittests 70.05% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/model.py 80.3% <66.66%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c280a4...ba851a9. Read the comment docs.

Copy link
Member

satra commented Apr 19, 2017
edited
Loading

@effigies - so film_gls needs a gifti with timeseries data right? do you know if it supports cifti directly?

	**--in <file>**	input data file ( NIFTI for volumetric, **GIFTI for surface** )
Optional arguments (You may optionally specify one or more of):
	--ac		perform autocorrelation estimation only
	--thr <num>	initial threshold to apply to input data
	--ar		fits autoregressive model - default is to use tukey with M=sqrt(numvols)
	--help		prints this message
	--noest		do not estimate auto corrs
	--outputPWdata		output prewhitened data and average design matrix
	--pava		estimates autocorr using PAVA - default is to use tukey with M=sqrt(numvols)
	--sa		smooths auto corr estimates
	-v		outputs full data
	--rn <file>	directory name to store results in, default is results
	--mode <mode>	analysis mode, options are volumetric ( default ) or surface. Caution: surface-based functionality is still BETA
	**--in2 <file>**	input surface for autocorr smoothing in surface-based analyses
	--mf <file>	re-estimate mean_func baseline - for use with perfusion subtraction
	--mft <file>	minimum timepoint file
	--pd <file>	paradigm file
	--con <file>	t-contrasts file
	--fcon <file>	f-contrasts file
	**--epith <num>**	susan brightness threshold for volumetric analysis/smoothing sigma for surface analysis
	**--ms <num>**	susan mask size for volumetric analysis/smoothing extent for surface analysis
	--tukey <num>	uses tukey window to estimate autocorr with window size num - default is to use tukey with M=sqrt(numvols)
	--mt <num>	uses multitapering with slepian tapers and num is the time-bandwidth product - default is to use tukey with M=sqrt(numvols)
	--ven		list of numbers indicating voxelwise EVs position in the design matrix (list order corresponds to files in vxf option). Caution BETA option, only use with volumetric analysis.
	--vef		list of 4D images containing voxelwise EVs (list order corresponds to numbers in vxl option). Caution BETA option, only use with volumetric analysis.

it may be good to ping the FSL folks for some examples here.

Copy link
Member Author

I haven't tried it. I've actually had difficulty getting it to run at all with GIFTI, so this is a little stalled until I have a bit more time to focus on it.

Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

do_tempfilter, basis_key)
nim = load(func_files[i])
(_, _, _, timepoints) = nim.shape
if hasattr(nim, 'get_arrays_from_intent'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about: timepoints = getattr(nim, 'get_arrys_from_intent', nim.shape[3])?

Copy link
Member Author

This pull request is "orphaned," which means it has been deemed to be abandoned by its original author. Orphaned pull requests have not been rejected, and we hope that if a user sees one that will meet their needs with a little work, that they will fork it and open a new pull request (or, in the case of the original author, reopen the original PR).

We ask that all adopted PRs be updated to merge or rebase the current master. If you would like to adopt a PR and need help getting started, any of a number of contributors will be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oesteban oesteban oesteban approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /