-
Notifications
You must be signed in to change notification settings - Fork 536
fix: closes #1920 to revert to original behavior for input names #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor comments.
nipype/interfaces/utility/base.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with => if/when?
nipype/interfaces/utility/base.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal preference (i.e. feel free to disregard):
if self.inputs.ravel_inputs: value = _ravel(value) out.extend(value)
or
out.extend(_ravel(value) if self.inputs.ravel_inputs else value)
@effigies - i pushed a few more changes in the tests - to no longer allow hstack of unitary inputs.
Sounds good. If tests pass, I'm good with this.
codecov-io
commented
Apr 5, 2017
Codecov Report
@@ Coverage Diff @@ ## master #1937 +/- ## ========================================== + Coverage 72.47% 72.47% +<.01% ========================================== Files 1063 1063 Lines 54148 54153 +5 Branches 7811 7811 ========================================== + Hits 39244 39249 +5 Misses 13684 13684 Partials 1220 1220
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@ ## master #1937 +/- ## ========================================== + Coverage 72.47% 72.47% +<.01% ========================================== Files 1063 1063 Lines 54148 54153 +5 Branches 7811 7811 ========================================== + Hits 39244 39249 +5 Misses 13684 13684 Partials 1220 1220
Continue to review full report at Codecov.
|
No description provided.