[ENH] Dockerfile - cache neurodebian apt-key #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

satra merged 2 commits into nipy:master from oesteban:enh/APTKeyCache

Feb 22, 2017

Merged

[ENH] Dockerfile - cache neurodebian apt-key #1837

satra merged 2 commits into nipy:master from oesteban:enh/APTKeyCache

Feb 22, 2017

Conversation

@oesteban

Copy link

Contributor

@oesteban oesteban commented Feb 22, 2017

Fixes #1834. Install a pre-cached key in the github repo instead
of fetching it from the server.

Nonetheless, I leave commented out the apt-key adv --recv key command
with the url @effigies suggested, just in case we would like to
roll back.

@oesteban


 [ENH] Dockerfile - cache neurodebian apt-key

Fixes nipy#1834. Install a pre-cached key in the github repo instead
of fetching it from the server.
Nonetheless, I leave commented out the apt-key adv --recv key command
with the url @effigies suggested, just in case we would like to
roll back.

@effigies

Copy link

Member

effigies commented Feb 22, 2017

👍 Pinning to a known key is way safer than grabbing from a keyserver every time. Biggest issue is not getting revocations or subkey rotations, though that should be handled by packages failing the apt-get checks when they start getting signed by a new key.

To check for revocations/etc, you could add apt-key adv --refresh-keys --keyserver hkp://ha.pool.sks-keyservers.net 0xA5D32F012649A5A9.

@oesteban


 add key refresh to dockerfile

b219b8f

@codecov-io

Copy link

codecov-io commented Feb 22, 2017

Codecov Report

Merging #1837 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@
## master #1837 +/- ##
==========================================
- Coverage 72.71% 72.71% -0.01% 
==========================================
 Files 1059 1059 
 Lines 52550 52550 
==========================================
- Hits 38212 38211 -1 
- Misses 14338 14339 +1

Flag	Coverage Δ
#unittests	`72.71% <ø> (-0.01%)`	❌

Impacted Files	Coverage Δ
nipype/interfaces/afni/base.py	`65.59% <ø> (-1.08%)`	❌

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f0444...b219b8f. Read the comment docs.