Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: Import NUMPY_MMAP inside functions #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oesteban merged 2 commits into nipy:master from effigies:bug/mmap
Feb 21, 2017
Merged

Conversation

@effigies
Copy link
Member

@effigies effigies commented Feb 21, 2017

Follow-up to #1796. Some imports were at the file level when they should have been at the function level. My criterion for moving was whether there are other function-local imports.

Addresses issue discovered in nipreps/fmriprep#362 (and nipreps/fmriprep#363).

Copy link
Member Author

cc @oesteban @satra for review. (Apparently requesting review is a privileged act? Weird.)

effigies added a commit to effigies/fmriprep that referenced this pull request Feb 21, 2017
Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@102d8d7). Click here to learn what that means.
The diff coverage is 0%.

@@ Coverage Diff @@
## master #1831 +/- ##
========================================
 Coverage ? 72.6% 
========================================
 Files ? 1054 
 Lines ? 52522 
 Branches ? 0 
========================================
 Hits ? 38134 
 Misses ? 14388 
 Partials ? 0
Flag Coverage Δ
#unittests 72.6% <ø> (?)
Impacted Files Coverage Δ
nipype/workflows/dmri/dipy/denoise.py 20.89% <ø> (ø)
nipype/workflows/dmri/fsl/utils.py 19.69% <ø> (ø)
nipype/workflows/dmri/fsl/epi.py 46.51% <ø> (ø)
nipype/interfaces/dipy/preprocess.py 23.25% <ø> (ø)
nipype/workflows/dmri/fsl/tbss.py 54.2% <ø> (ø)
nipype/workflows/misc/utils.py 15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102d8d7...72cb924. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oesteban oesteban oesteban approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /