-
Notifications
You must be signed in to change notification settings - Fork 114
Fixing tests #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nilportugues
merged 3 commits into
php81-upgrade-strict-types
from
jules_wip_4127558850548469923
Jun 5, 2025
Merged
Fixing tests #135
nilportugues
merged 3 commits into
php81-upgrade-strict-types
from
jules_wip_4127558850548469923
Jun 5, 2025
+45
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... done so far and provide feedback for Jules to continue.
This commit addresses several issues related to column alias generation: 1. **Standardized `SyntaxFactory::createColumn` behavior:** The `createColumn` method in `src/Syntax/SyntaxFactory.php` now consistently creates an alias if a string key is provided in the column definition array (e.g., `['my_alias' => 'column_name']`). This applies even if the alias string is the same as the column name. This change resolved multiple test failures where such aliases were expected but not generated by the previous, more restrictive logic. 2. **Fixed subquery alias derivation in `ColumnWriter`:** The `selectColumnToQuery` method in `src/Builder/Syntax/ColumnWriter.php` was updated to correctly handle subqueries (Select objects) passed with numeric keys. - Resolved a fatal error caused by an incorrect call to `Select::getFrom()`; it now correctly uses `Select::getTable()` to access the subquery's main table. - Implemented logic to derive the column alias from the subquery's main table's alias or name, if available. This fixed critical test failures where aliases like `AS "role"` were missing for subqueries. These changes have significantly reduced the number of failing tests and resolved critical errors, paving the way for addressing the remaining specific test cases.
... done so far and provide feedback for Jules to continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.