Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: rename requirements-3.txt to requirements.txt in build.sh #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s00hyun wants to merge 1 commit into nickmaccarthy:master from s00hyun:build-fix

Conversation

@s00hyun
Copy link

@s00hyun s00hyun commented Sep 12, 2024
edited
Loading

I just came across this while looking into the repository. It looks like requirements-3.txt was renamed as requirements.txt but not in build.sh. Please feel free to merge this or not.

Copy link
Author

s00hyun commented Sep 12, 2024
edited
Loading

python2.7 related lines might be obsolete too, as python2 support has been deprecated?
+) should support python >=3.8 only

I will just wait for a comment as it looks like build.sh is obsolete and .github/workflows/release.yaml is in use tho..

Copy link
Owner

yeah, we can skip this one for now @s00hyun, but thank you for your contribution ! The build.sh was there before we had github actions involved. I'm just to remove it in a future release

s00hyun reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /