-
-
Notifications
You must be signed in to change notification settings - Fork 99
fix handleBeforeInput on v3 of draft plugins editor; #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2019
jhackett1
commented
Jan 5, 2020
thanks! your fix worked for me too. so simple!
@ngs any chance of merging this?
thecodedrift
commented
Feb 21, 2020
This fixes #61
tmathew0309
commented
Mar 23, 2020
This worked for me. @ngs can we get this merged soon?
alibosworth
commented
Mar 27, 2020
Fix works for me too. @ngs please merge otherwise we need to fork to our own version
alibosworth
added a commit
to flowapp/draft-js-markdown-shortcuts-plugin
that referenced
this pull request
Mar 27, 2020
Found this here ngs#62 It is required to use with new draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the
setEditorState is not a functionbug for my setup.In the plugins editor the
handleBeforeInputchanged,eventTimeStampwas added.https://github.com/draft-js-plugins/draft-js-plugins/blob/93f9d32b703cf8e65e3576a5803388b362d19ba5/draft-js-plugins-editor/src/index.d.ts#L65
Updated dependencies and especially the
draft-js-plugins-editorand added the propertyeventTimeStampin theindex.jsNot really sure if this was everything.
Tested in an app with multiple editors on the same page and different draft js plugins.
Versions of the app tested:
That's why the dependency version range is tightened, as e.g. draft-js-plugins-editor 3 needs React 16.3 as minimum.
As temporary fix I published the changes as draft-js-md-keyboard-plugin
Would be great if someone checks it also and I hope this help!