-
-
Notifications
You must be signed in to change notification settings - Fork 962
Rewrite mTLS logic #3685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Rewrite mTLS logic #3685
+120
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
good to remove the certificate to account and move for host !!
< pls rebase >
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
ReanimationXP
commented
Oct 1, 2025
does this commit mean mTLS certs can be imported and used for Cloudflare Tunnels / Zero Trust? do we know when this can be merged?
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Use Keychain to save Identity instead of NCPreferences
Delete old Identity in keychain before replacing
Make NCLoginProvider also check for Identity
TODO:
Test if Keychain can accept multiple different identities from a domain with different ports (ex localhost)
Test cert expiration