-
Notifications
You must be signed in to change notification settings - Fork 896
Add Community Container documentation #6173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@szaimen WDYT ?
8e76d21 to
6c18d57
Compare
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
6c18d57 to
996ae3a
Compare
@szaimen WDYT ?
Looks already really cool, thanks for this initiative! 😊
Btw, maybe we should link this doc in this section https://github.com/nextcloud/all-in-one/tree/main/community-containers#how-to-add-containers and/or put it directly into the readme file as additonal section? Not sure what the best approach would be...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably state in the docs that the options here are not considered inside aio. Same for other things like profiles and user...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these options need to be set in the Dockerfile of the container...
Hi @docjyJ any update here? :)
What elements are not supported?
What elements are not supported?
The healthcheck options and some other things like profiles and user are not actually forwarded to the container. See #5574 (comment) so we should make that clear in the docs that they need to be set directly in the Dockerfile of the container instead imho
No description provided.