-
-
Couldn't load subscription status.
- Fork 34
Bug fix: problem with concurrency under stress #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cca48ef to
45d6775
Compare
Wouldn't it be better to set setAutoRefresh(false) in this case ?
In a development environment it's expected that new classes may appear, so auto refresh is needed.
But on the same development environment, PHPStan aggressively creates cache files as PHP code. Other environments could have similar issues as it is fairly common for PHP files to be used for caching systems.
I believe my PR provides a pretty modest solution to that, just making things a bit more configurable.
(Looking at it now I can see somehow it got noisy with other commits, so just look at the ones I did please.)
This adds additional configurability to RobotLoader, to minimize unnecessary cache rewrites during stress. This reduces the chance of concurrency problems.