Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade to EasyCodingStandard 2.2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dg merged 6 commits into master from upgrade-ecs-22
Jul 27, 2017
Merged

Upgrade to EasyCodingStandard 2.2 #14

dg merged 6 commits into master from upgrade-ecs-22
Jul 27, 2017

Conversation

@TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Jul 27, 2017
edited
Loading

  • upgrade to ECS 2.2
  • fix travis checking code (was not running at all)
  • check /src directory as well
  • fix cs (of course :))

composer.json Outdated
"friendsofphp/php-cs-fixer": "^2.4",
"slevomat/coding-standard": "^3.0"
"symplify/easy-coding-standard": "^2.2.1",
"friendsofphp/php-cs-fixer": "^2.4"
Copy link
Contributor Author

@TomasVotruba TomasVotruba Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slevomat/coding-standard is required by ecs by default, it uses few of it's utilies and defacto must-have standard

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you can give it away.

Copy link
Contributor Author

@TomasVotruba TomasVotruba Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I think friendsofphp/php-cs-fixer can be removed too, as it is the core part of ecs

Copy link
Contributor Author

TomasVotruba commented Jul 27, 2017
edited
Loading

Ready to merge. @dg Could you review please?

@dg
Copy link
Member

dg commented Jul 27, 2017

Great, thanks!

TomasVotruba reacted with thumbs up emoji

@dg dg merged commit ec67b9b into master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dg dg dg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /