-
Couldn't load subscription status.
- Fork 19
fix: don't use peer deps - use regular deps #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the behavior of match (v2 of router) / matchPath (v1 of router) did not change - with move to actual dependency we don't need to pick one or the other and can straight import match as reachMatch
Uh oh!
There was an error while loading. Please reload this page.
Summary
This removes peer deps usage of build plugin - those cause problems in autoinstallation scenarios with package managers that enforce strict dependencies / no hoisting scenarios (for example by default with pnpm)
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
https://linear.app/netlify/issue/COM-225/netlify-dev-fails-on-monorepo-setup#comment-a8eee1ec
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was
published correctly.