Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: use ImageHandler from @netlify/images #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keanu-a wants to merge 8 commits into main
base: main
Choose a base branch
Loading
from keanualoua/ex-536-use-imagehandler-from-netlifyimages

Conversation

@keanu-a
Copy link
Contributor

@keanu-a keanu-a commented Aug 26, 2025
edited
Loading

🎉 Thanks for submitting a pull request! 🎉

Summary

Refactors logic of the initializeImageProxy function to use @netlify/images instead of express function. Removed unit tests for the old logic as well.

Fixes #EX-536


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@keanu-a keanu-a changed the title (削除) refactor: change initializeProxy to use ImageHandler (削除ここまで) (追記) refactor: use ImageHandler from @netlify/images (追記ここまで) Aug 26, 2025
Copy link

github-actions bot commented Aug 26, 2025
edited
Loading

📊 Benchmark results

Comparing with 3539b0d

  • Dependency count: 1,074 ⬆️ 0.09% increase vs. 3539b0d
  • Package size: 298 MB ⬆️ 0.01% increase vs. 3539b0d
  • Number of ts-expect-error directives: 381 (no change)

@keanu-a keanu-a marked this pull request as ready for review August 26, 2025 21:03
@keanu-a keanu-a requested a review from a team as a code owner August 26, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /