-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closes: #17936 - GFK serializer field #20706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+119
−318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bctiemann
bctiemann
requested review from
a team and
jeremystretch
and removed request for
a team
October 29, 2025 20:25
jeremystretch
jeremystretch
requested changes
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two serializers with generic foreign keys where GFKSerializerField is not being employed, presumably due to variations in the resolution logic.
ObjectChangeSerializer.changed_object: Suggest we replace the SerializerMethodField with GFKSerializerField, and exposeobject_repras a regular read-only field. IMO this cleaner than the current fallback behavior.EventRuleSerializer.action_object: I don't think the custom logic underget_action_object()is necessary anymore as there is a now a Script model: The automatic resolution should work.
...EventRuleSerializer.action_object
Added those two; tested successfully, works nice. Added ObjectChangeSerializer.object_repr as a read-only CharField.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17936