-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fixes #20610: Correct VLAN ID range calculation logic #20611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20610: Correct VLAN ID range calculation logic #20611
Conversation
Thanks for all the release work!
If it’s still feasible, could this be included in v4.4.5? It fixes a regression I introduced in v4.4.3 (#20610) that miscounts _total_vlan_ids. I’m sorry for the slip.
No pressure if the window has closed. I completely understand. I can rebase or adjust anything right away if that helps.
Thanks again for your time and for everything you do.
I'll try to review this tomorrow ahead of the v4.4.5 release if @bctiemann hasn't had a chance yet.
netbox/ipam/migrations/0083_vlangroup_populate_total_vlan_ids.py
Outdated
Show resolved
Hide resolved
Adjust VLAN ID range calculation to use half‐open intervals for consistency. Add a test to validate `_total_vlan_ids`. Fixes netbox-community#20610
369cd6a to
05fd14a
Compare
Thanks for the thoughtful review!
I’ve rebased and switched the migration to use bulk_update() as suggested. Please take another look when you have a moment. Happy to adjust anything further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pheus!
afc62b6
into
netbox-community:main
Fixes: #20610
Correct an off‐by‐one in
VLANGroup._total_vlan_idsby computing lengths with half‐open[lo, hi)semantics duringsave(). Removes the+1, adds a test and includes a data migration to backfill existing_total_vlan_ids.No schema changes.