Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add jinja2 support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prokaktus wants to merge 1 commit into nephila:develop
base: develop
Choose a base branch
Loading
from prokaktus:jinja2-support
Open

Conversation

@prokaktus
Copy link

@prokaktus prokaktus commented Jun 30, 2017

Address #57

Copy link

codecov bot commented Jun 30, 2017
edited
Loading

Codecov Report

Merging #60 into develop will decrease coverage by 3.62%.
The diff coverage is 17.64%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
- Coverage 96.9% 93.27% -3.63% 
===========================================
 Files 7 8 +1 
 Lines 355 372 +17 
 Branches 38 39 +1 
===========================================
+ Hits 344 347 +3 
- Misses 7 21 +14 
 Partials 4 4
Impacted Files Coverage Δ
meta/jinja2.py 17.64% <17.64%> (ø)
meta/__init__.py
meta/models.py
meta/views.py
tests/example_app/views.py 95.56% <0%> (ø)
tests/example_app/migrations/__init__.py 100% <0%> (ø)
tests/example_app/models.py 98.79% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e740f...830e9db. Read the comment docs.

Copy link

coveralls commented Jun 30, 2017
edited
Loading

Coverage Status

Coverage decreased (-3.7%) to 94.355% when pulling 830e9db on prokaktus:jinja2-support into 21e740f on nephila:develop.

2 similar comments
Copy link

Coverage Status

Coverage decreased (-3.7%) to 94.355% when pulling 830e9db on prokaktus:jinja2-support into 21e740f on nephila:develop.

Copy link

Coverage Status

Coverage decreased (-3.7%) to 94.355% when pulling 830e9db on prokaktus:jinja2-support into 21e740f on nephila:develop.

Copy link

coveralls commented Jun 30, 2017
edited
Loading

Coverage Status

Coverage decreased (-2.6%) to 95.43% when pulling b3b5123 on prokaktus:jinja2-support into 21e740f on nephila:develop.

4 similar comments
Copy link

Coverage Status

Coverage decreased (-2.6%) to 95.43% when pulling b3b5123 on prokaktus:jinja2-support into 21e740f on nephila:develop.

Copy link

Coverage Status

Coverage decreased (-2.6%) to 95.43% when pulling b3b5123 on prokaktus:jinja2-support into 21e740f on nephila:develop.

Copy link

Coverage Status

Coverage decreased (-2.6%) to 95.43% when pulling b3b5123 on prokaktus:jinja2-support into 21e740f on nephila:develop.

Copy link

Coverage Status

Coverage decreased (-2.6%) to 95.43% when pulling b3b5123 on prokaktus:jinja2-support into 21e740f on nephila:develop.

</body>
</html>

#. For Jinja2 support, configure your environment::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can move the jinja2 section to a dedicated page?

Copy link
Member

@yakky yakky left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it's great! Thank you for this very nice addition
See my comment related to the doc page
See also test failures
Any approach to testing this?

Copy link
Member

yakky commented Dec 31, 2017

@prokaktus any update on this? Do you need any help to get this merged?

Copy link
Author

@yakky hi! Thanks for your attention. I've stopped using this fix with my fork, but it would be much nicer to prepare fix for the main version!

I will work for a proper fix in the following couple days.

Copy link
Member

yakky commented Dec 31, 2017

@prokaktus that would be awesome! Thanks and let me know if you need help. New year resolution is to be more active and helpful here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakky yakky yakky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /