-
Notifications
You must be signed in to change notification settings - Fork 41
refactor: Add bolt message objects #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PHP CS Fixer still has an issue described in #247 (comment). Once we come to a conclusion on that and merge that PR in, we should merge main into this one and that CI should pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing Nabeel! Before properly merging we can't forget to do the messages for the Authentication. Can you take care of that as well please?
...lasses (#254) * Extracted HELLO, LOGON, and LOGOFF message creation into dedicated classes - Updated BasicAuth, KerberosAuth, NoAuth, and OpenIDConnectAuth to utilize new message classes - Added unit tests for each message class and authentication strategy * Fixed cluster tests --------- Co-authored-by: pratikshazalte69 <pratikshazalte69@gmail.com>
Thanks @p123-stack for the Authentication related messages 🙌
This PR aims to add an abstraction over the bolt messages.
It adds classes for individual messages and a factory for easily creating them.