Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Remove OGMFormatter #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
transistive merged 3 commits into feat/remove-http from feat/remove-formatter
Jan 24, 2025
Merged

Conversation

@exaby73
Copy link
Collaborator

@exaby73 exaby73 commented Jan 24, 2025

No description provided.

## Result formats/hydration

In order to make the results of the bolt protocol and the http uniform, the driver provides result formatters (aka hydrators). The client is configurable with these formatters. You can even implement your own.
In order to make the results of the bolt protocol and the http uniform, the driver provides a summarizes the results.
Copy link
Contributor

@stefanak-michal stefanak-michal Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be: provides and summarizes ?

Copy link
Collaborator

@transistive transistive Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it to me too! It's probably a simple typo. Good catch @stefanak-michal

Copy link
Collaborator

@transistive transistive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR, the reduction of code brings a tear to my eye, all while not losing out on type safety 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@transistive transistive transistive approved these changes

+1 more reviewer

@stefanak-michal stefanak-michal stefanak-michal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /