-
Notifications
You must be signed in to change notification settings - Fork 2
chore: cleanup codes #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance Report
Merging #33 will not alter performance
Comparing 10-13-chore_cleanup_codes (02d76d8) with main (f472ff8)
Summary
✅ 3 untouched
⏩ 9 skipped1
Footnotes
-
9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
c8d125f to
c3e9712
Compare
@codex review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs code cleanup across SIMD implementations, introducing AddressSanitizer (ASAN) testing and refactoring common patterns for consistency.
- Extracts hardcoded lane counts into a constant for better maintainability
- Replaces direct bit manipulation with trait methods for cleaner API usage
- Adds comprehensive ASAN testing in CI for memory safety validation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/simd/v128.rs | Introduces LANES constant and replaces hardcoded values; updates bit mask operations to use trait methods |
| src/simd/sse2.rs | Updates array declarations and pointer operations to use LANES constant; replaces trailing_zeros with first_offset |
| src/simd/neon.rs | Applies consistent LANES constant usage and standardizes placeholder array access patterns |
| src/simd/avx512.rs | Standardizes pointer operations with slice syntax for consistency |
| src/simd/avx2.rs | Updates array access patterns to use slice syntax consistently |
| .github/workflows/CI.yml | Adds comprehensive ASAN testing job for both Linux and Windows platforms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codex Review: Didn't find any major issues. Nice work!
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
chore: cleanup codes
add asan