-
Notifications
You must be signed in to change notification settings - Fork 205
Fix deadlock in mysql poolmanager attempt #2 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...eAwait(false). That affects all apps with SynchronizationContext for example: ASP.NET MVC fullframework app, Windows Forms app, WPF app.
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
mysql-oca-bot
commented
Mar 8, 2024
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=114272 for updates.
Thanks
siickstar
commented
Jun 6, 2024
I Fucking Love you, thanks from the bottom of my heart, you saved my job and my sanity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PR again as my previous PR #60 was not processed due to OCA - which is now sorted out.
There is deadlock bug in MySqlPoolManager.cs. It makes the library unusable in any .Net applications with SynchronizationCotnext while using pooling feature.
It causes a deadlock of threads, application will hang forever. Affected are:
If using Pooling=true in connection string (common scenario).
What is more, it leads to breaking the whole appPool on IIS (for ASP .NET MVC app) as all threads from thread pool will eventually deadlock.
This looks like obvious human error, there is missing ConfigureAwait(false) when awaiting on semaphore. Note that the ConfigureAwait(false) is widely used in all other places at this class but in this one is simply missing.
In this PR:
How bug was introduced