-
-
Notifications
You must be signed in to change notification settings - Fork 895
Fix RPI GW poor RSSI on RFM69 (#1077) #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix mysensors#1077 Use radio auto standby mode to get correct RSSI value. Details https://git.io/JXHrE
8d39ba8 to
0c3e52c
Compare
piotrraczynski
commented
Dec 27, 2021
it seems that this PR was sitting here for a while and CI results are gone. Can we get the checks re-run?
Sorry for the delay. I have re-run the build. The butler complains about styling. The suggested patch is available at https://ci.mysensors.org/job/MySensors/job/MySensors/job/PR-1511/9/execution/node/4/ws/MySensors/restyling.patch
Contents:
diff --git a/hal/transport/RFM69/driver/new/RFM69_new.cpp b/hal/transport/RFM69/driver/new/RFM69_new.cpp
index e1620d4..ff06160 100644
--- a/hal/transport/RFM69/driver/new/RFM69_new.cpp
+++ b/hal/transport/RFM69/driver/new/RFM69_new.cpp
@@ -734,7 +734,7 @@ LOCAL void RFM69_setConfiguration(void)
{ RFM69_REG_PAYLOADLENGTH, RFM69_MAX_PACKET_LEN }, // in variable length mode: the max frame size, not used in TX
{ RFM69_REG_NODEADRS, RFM69_BROADCAST_ADDRESS }, // init
{ RFM69_REG_BROADCASTADRS, RFM69_BROADCAST_ADDRESS },
- { RFM69_REG_AUTOMODES , RFM69_AUTOMODES_ENTER_PAYLOADREADY | RFM69_AUTOMODES_EXIT_FIFOEMPTY | RFM69_AUTOMODES_INTERMEDIATE_STANDBY },
+ { RFM69_REG_AUTOMODES, RFM69_AUTOMODES_ENTER_PAYLOADREADY | RFM69_AUTOMODES_EXIT_FIFOEMPTY | RFM69_AUTOMODES_INTERMEDIATE_STANDBY },
{ RFM69_REG_FIFOTHRESH, RFM69_FIFOTHRESH_TXSTART_FIFOTHRESH | (RFM69_HEADER_LEN - 1) }, // start transmitting when rfm69 header loaded, fifo level irq when header bytes received (irq asserted when n bytes exceeded)
{ RFM69_REG_PACKETCONFIG2, RFM69_PACKET2_RXRESTARTDELAY_2BITS | RFM69_PACKET2_AUTORXRESTART_OFF | RFM69_PACKET2_AES_OFF },
{ RFM69_REG_TESTDAGC, RFM69_DAGC_IMPROVED_LOWBETA0 }, // continuous DAGC mode, use 0x30 if afc offset == 0
Would you mind applying the patch (or remove the single white space manually) ? When that is done, we should be able to get a good build.
fix #1077 Use radio auto standby mode to get correct RSSI value.
Details #1077 (comment)