-
Notifications
You must be signed in to change notification settings - Fork 97
Grammarly issue #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Grammarly issue #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...toClose option The `vue-html-to-paper.js` file has been updated to include support for two new options: `windowTitle` and `autoClose`. The `windowTitle` option allows the user to specify a custom title for the print window, while the `autoClose` option allows the user to control whether the print window should automatically close after printing or not. The `setTimeout` function has been updated to check the value of `autoClose` before closing the window. 🔧 chore(index.js): add autoClose and windowTitle options to VueHtmlToPaper This commit adds two new options to the VueHtmlToPaper object: autoClose and windowTitle. The autoClose option allows the user to specify whether the print window should automatically close after printing. The windowTitle option allows the user to specify a custom title for the print window. These options can be passed in as localOptions or as part of the global options object. 🔧 chore(index.js): add autoClose and windowTitle options to VueHtmlToPaper This commit adds two new options to the VueHtmlToPaper object: autoClose and windowTitle. The autoClose option allows the user to specify whether the print window should automatically close after printing. The windowTitle option allows the user to specify a custom title for the print window. These options can be passed in as localOptions or as part of the global options object.
chris-jamieson
commented
Jul 8, 2024
Just a note to say I also experienced this issue. Thanks for working on a fix.
You are welcome
... On Mon, 8 Jul 2024, 16:18 Chris Jamieson, ***@***.***> wrote:
Just a note to say I also experienced this issue. Thanks for working on a
fix.
—
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARHTQCBCKTABS3FPJZDZQTZLJU77AVCNFSM6AAAAABIMXZCIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTGY3TAMZTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with both vue2 and vue3 versions. The issue is if you have Grammarly enabled print popup windows autoclose without print or if you disabled autoclose popup will load forever I did a simple fix to sort this issue.